Skip to content

Wraps chrome.storage with try/catch#802

Open
Nantris wants to merge 1 commit into
zalmoxisus:masterfrom
Nantris:master
Open

Wraps chrome.storage with try/catch#802
Nantris wants to merge 1 commit into
zalmoxisus:masterfrom
Nantris:master

Conversation

@Nantris

@Nantris Nantris commented Jun 4, 2021

Copy link
Copy Markdown

Fixes #767

@Nantris

Nantris commented Jun 4, 2021

Copy link
Copy Markdown
Author

If anyone knows the correct typeof for chrome.storage.sync that we could check against, that would be cleaner than my current solution.

@userlerueda

Copy link
Copy Markdown

@slapbox do you want to try to get this PR integrated in the new repo they posted to see if this can be fixed?
https://github.com/reduxjs/redux-devtools/blob/main/extension/src/browser/extension/options/syncOptions.ts

I can submit the change but since you were the one who spotted the problem.

@Nantris

Nantris commented Mar 1, 2022

Copy link
Copy Markdown
Author

@userlerueda if you have the bandwidth to resubmit this PR there, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors logged on startup in Electron 10

2 participants